Skip to content

Comments

YARN-11504. [Addendum] [Federation] YARN Federation Supports Non-HA mode#5746

Merged
slfan1989 merged 1 commit intoapache:trunkfrom
yl09099:YARN-11504
Jun 14, 2023
Merged

YARN-11504. [Addendum] [Federation] YARN Federation Supports Non-HA mode#5746
slfan1989 merged 1 commit intoapache:trunkfrom
yl09099:YARN-11504

Conversation

@yl09099
Copy link
Contributor

@yl09099 yl09099 commented Jun 14, 2023 •
edited
Loading

Description of PR

When I was submitting (#5716) the PR, I found that junit reported an error, I took a closer look at this piece of code, and we should consider the logic for compatibility with HA

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@yl09099
Copy link
Contributor Author

yl09099 commented Jun 14, 2023

@slfan1989 I took a closer look at this piece of code, and we should consider the logic for compatibility with HA，Please review it

@slfan1989
Copy link
Contributor

slfan1989 commented Jun 14, 2023

@yl09099 Thanks for your contribution, LGTM.

@hadoop-yetus
Copy link

hadoop-yetus commented Jun 14, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 29s trunk passed
+1 💚 compile 0m 49s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 0m 43s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 46s trunk passed
+1 💚 mvnsite 0m 54s trunk passed
+1 💚 javadoc 1m 4s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 52s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 1m 55s trunk passed
+1 💚 shadedclient 23m 55s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 38s the patch passed
+1 💚 compile 0m 41s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 0m 41s the patch passed
+1 💚 compile 0m 36s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 36s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 29s the patch passed
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 javadoc 0m 42s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 0m 43s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 1m 50s the patch passed
+1 💚 shadedclient 24m 17s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 5m 44s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
109m 4s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5746/1/artifact/out/Dockerfile
GITHUB PR #5746
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 1130be57c022 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d087da0
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5746/1/testReport/
Max. process+thread count 704 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5746/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

slfan1989 commented Jun 14, 2023

@yl09099 Thank you for your feedback! Upon reviewing the code, I found that we execute the specified logic in non-HA mode. However, when HA is enabled, it should remain consistent with the original logic. Merged Into trunk.

@slfan1989 slfan1989 merged commit f4accec into apache:trunk Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slfan1989 slfan1989 slfan1989 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yl09099 @slfan1989 @hadoop-yetus